Skip to content

fix: typing error with props and attributes #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2018
Merged

fix: typing error with props and attributes #433

merged 2 commits into from
Feb 16, 2018

Conversation

vwxyutarooo
Copy link
Contributor

For #432

@vwxyutarooo vwxyutarooo changed the title fix: yping error with props an attributes fix: typing error with props an attributes Feb 15, 2018
@vwxyutarooo vwxyutarooo changed the title fix: typing error with props an attributes fix: typing error with props and attributes Feb 16, 2018
kazupon
kazupon approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.
ref: implementation of props
https://github.com/vuejs/vue-test-utils/blob/dev/src/wrappers/wrapper.js#L390

eddyerburgh
eddyerburgh approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😀

@eddyerburgh eddyerburgh merged commit cf55756 into vuejs:dev Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

+1 more reviewer

@kazupon kazupon kazupon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vwxyutarooo @kazupon @eddyerburgh